bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(form-field): add form_field_options table, service, scope, cascade

Browse Source 
Fourth and final WS-5 sibling. Polymorphic morph-owned table for the
RADIO / SELECT / MULTISELECT / CHECKBOX_LIST option rows, shared
between form_fields and form_field_library via the owner_type
discriminator. Matches the WS-5a (bindings) / WS-5b (validation_rules
+ configs) pattern one-for-one: dedicated service as single writer,
UNION-over-two-owner-chains scope, shared cascade observer.

Row shape:
  - value         canonical storage value (string ≤255, UNIQUE per owner)
  - label         default-locale display label (string ≤255)
  - sort_order    int unsigned
  - translations  JSON { "<locale>": "<translated label>" }

The UNIQUE(owner_type, owner_id, value) index ffo_owner_value_unique
is the seed-bug guard — duplicate values per field have no semantic
meaning and must fail at both the service layer (assertSpecsValid)
and the DB level.

Activity log: field.options_replaced emits on FormField subject only,
per the §6.7 WS-5a / §17.4.2 WS-5b convention that library-level
changes are silent in activity log.

No production reads yet. The form_fields.options and
form_field_library.options JSON columns remain the active source of
truth until the commit-3 reader switch — accessing $field->options
still resolves through the JSON cast in commit 1, so model tests
exercise the new morphMany via $field->options() (explicit relation
call). Both FormField and FormFieldLibrary now carry an `options`
morphMany alongside `bindings`, `validation_rules`, and `configs`.

Cascade: FormFieldChildTablesCascadeObserver gains form_field_options
as the fourth child cleaned on owner delete (both FormField soft/
force-delete and FormFieldLibrary delete).

Migration step-count tests in WS-5a/b/c bumped by 1 to account for
the new create_form_field_options_table on the migration stack.

Base scope-class extraction across the four siblings — deliberately
deferred to a follow-up work package per addendum §17.4.3 / §17.5.3.
Now that all four concrete implementations exist, the "what actually
varies" question can be answered empirically.

Tests: 1158 → 1182 green (+24 tests / +42 assertions).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-04-25 02:07:53 +02:00
parent e17fc7c2f4
commit 11588623c5
13 changed files with 1078 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
api/tests/Feature/FormBuilder/Bindings/FormFieldBindingMigrationTest.php
View File

@@ -33,13 +33,14 @@ final class FormFieldBindingMigrationTest extends TestCase
public function test_forward_migrations_backfill_rows_from_both_json_sources(): void
{
// Roll back to pre-WS-5a state: 3 WS-5c migrations
// (backfill-conditional-logic, create-conditional-logic-conditions,
// Roll back to pre-WS-5a state: 1 WS-5d migration (create-options) +
// 4 WS-5c migrations (drop-conditional-logic-col,
// backfill-conditional-logic, create-conditional-logic-conditions,
// create-conditional-logic-groups) + 5 WS-5b migrations
// (drop-validation-cols, configs-backfill, create-configs,
// validation-rules-backfill, create-validation-rules) +
// 2 WS-5a migrations (drop-binding-cols, create-bindings) = 10.
$this->artisan('migrate:rollback', ['--step' => 11])->assertSuccessful();
// 2 WS-5a migrations (drop-binding-cols, create-bindings) = 12.
$this->artisan('migrate:rollback', ['--step' => 12])->assertSuccessful();
$this->assertFalse(Schema::hasTable('form_field_bindings'));
$this->assertTrue(Schema::hasColumn('form_fields', 'binding'));
$this->assertTrue(Schema::hasColumn('form_field_library', 'default_binding'));
@@ -100,8 +101,8 @@ final class FormFieldBindingMigrationTest extends TestCase
public function test_rollback_reconstructs_json_and_drops_table(): void
{
// Walk back the full WS-5c + WS-5b + WS-5a stack (10 migrations).
$this->artisan('migrate:rollback', ['--step' => 11])->assertSuccessful();
// Walk back the full WS-5d + WS-5c + WS-5b + WS-5a stack (12 migrations).
$this->artisan('migrate:rollback', ['--step' => 12])->assertSuccessful();
[$fieldAId, , ] = $this->seedFieldsWithBindingJson();
[$libAId, ] = $this->seedLibraryWithBindingJson();
@@ -111,11 +112,13 @@ final class FormFieldBindingMigrationTest extends TestCase
$this->assertFalse(Schema::hasColumn('form_fields', 'binding'));
$this->assertSame(5, DB::table('form_field_bindings')->count());
// Step back over WS-5c (3 migrations) + WS-5b (5 migrations) in one
// go → restores the pre-WS-5b state (conditional-logic,
// validation-rules and configs tables gone, validation_rules JSON
// columns reappear on source tables; binding contract intact).
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
// Step back over WS-5d (1 migration) + WS-5c (4 migrations) +
// WS-5b (5 migrations) in one go → restores the pre-WS-5b state
// (conditional-logic, validation-rules, configs and options tables
// gone, validation_rules JSON columns reappear on source tables;
// binding contract intact).
$this->artisan('migrate:rollback', ['--step' => 10])->assertSuccessful();
$this->assertFalse(Schema::hasTable('form_field_options'));
$this->assertFalse(Schema::hasTable('form_field_conditional_logic_groups'));
$this->assertFalse(Schema::hasTable('form_field_conditional_logic_conditions'));
$this->assertFalse(Schema::hasTable('form_field_validation_rules'));

12
api/tests/Feature/FormBuilder/ConditionalLogic/ConditionalLogicBackfillTest.php
View File

@@ -31,8 +31,10 @@ final class ConditionalLogicBackfillTest extends TestCase
public function test_forward_backfill_builds_nested_tree_from_legacy_json(): void
{
// Roll back only the backfill migration (latest WS-5c step).
$this->artisan('migrate:rollback', ['--step' => 2])->assertSuccessful();
// Roll back the WS-5d create-options + WS-5c drop-cl-col + WS-5c
// backfill-cl migrations to land in the conditional-logic JSON-era
// state with no relational form_field_options table yet.
$this->artisan('migrate:rollback', ['--step' => 3])->assertSuccessful();
$this->assertTrue(Schema::hasColumn('form_fields', 'conditional_logic'));
$fieldId = $this->seedFieldWithJson([
@@ -153,7 +155,7 @@ final class ConditionalLogicBackfillTest extends TestCase
]);
// Roll back only the backfill migration — writes the JSON back.
$this->artisan('migrate:rollback', ['--step' => 2])->assertSuccessful();
$this->artisan('migrate:rollback', ['--step' => 3])->assertSuccessful();
$reconstructed = DB::table('form_fields')
->where('id', $fieldId)
@@ -180,7 +182,7 @@ final class ConditionalLogicBackfillTest extends TestCase
public function test_unknown_top_level_key_fails_migration(): void
{
$this->artisan('migrate:rollback', ['--step' => 2])->assertSuccessful();
$this->artisan('migrate:rollback', ['--step' => 3])->assertSuccessful();
$this->seedFieldWithJson([
'hide_when' => ['all' => [['field_slug' => 'x', 'operator' => 'equals', 'value' => 1]]],
@@ -193,7 +195,7 @@ final class ConditionalLogicBackfillTest extends TestCase
public function test_unknown_comparison_operator_fails_migration(): void
{
$this->artisan('migrate:rollback', ['--step' => 2])->assertSuccessful();
$this->artisan('migrate:rollback', ['--step' => 3])->assertSuccessful();
$this->seedFieldWithJson([
'show_when' => ['all' => [['field_slug' => 'x', 'operator' => 'matches_regex', 'value' => 'y']]],

442
api/tests/Feature/FormBuilder/Options/FormFieldOptionServiceAndScopeTest.php Normal file
View File

@@ -0,0 +1,442 @@
<?php
declare(strict_types=1);
namespace Tests\Feature\FormBuilder\Options;
use App\Exceptions\FormBuilder\InvalidOptionSpecException;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldLibrary;
use App\Models\FormBuilder\FormFieldOption;
use App\Models\FormBuilder\FormSchema;
use App\Models\Organisation;
use App\Models\Scopes\FormFieldOptionScope;
use App\Services\FormBuilder\FormFieldOptionService;
use Illuminate\Database\QueryException;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Routing\Route;
use Spatie\Activitylog\Models\Activity;
use Tests\TestCase;
/**
* Consolidated coverage for `form_field_options` — model relation,
* scope isolation, cascade, and service-layer contract (replace, copy,
* toJsonShape, assertSpecsValid). Mirrors the structure of the
* configs / validation-rules test suites (WS-5b).
*/
final class FormFieldOptionServiceAndScopeTest extends TestCase
{
use RefreshDatabase;
public function test_field_morph_many_options_and_owner_morphto_roundtrip(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldOption::factory()->forField($field)->create([
'value' => 'xs', 'label' => 'XS', 'sort_order' => 0,
]);
FormFieldOption::factory()->forField($field)->create([
'value' => 'sm', 'label' => 'S', 'sort_order' => 1,
]);
// Commit 1 coexistence: form_fields.options JSON cast still exists,
// so $field->options resolves to the array attribute rather than
// the morphMany. Explicit relation call until commit 3 drops the
// cast.
$options = $field->fresh()->options()->get();
$this->assertCount(2, $options);
$this->assertSame(['xs', 'sm'], $options->pluck('value')->all());
$this->assertSame(FormField::class, $options->first()->fresh()->owner::class);
}
public function test_library_morph_many_options_resolves(): void
{
$org = Organisation::factory()->create();
$library = FormFieldLibrary::factory()->create(['organisation_id' => $org->id]);
FormFieldOption::factory()->forLibrary($library)->create([
'value' => 'a', 'label' => 'A', 'sort_order' => 0,
]);
$this->assertSame(
FormFieldLibrary::class,
$library->fresh()->options()->get()->first()->fresh()->owner::class,
);
}
public function test_to_json_shape_omits_empty_translations(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
$option = FormFieldOption::factory()->forField($field)->create([
'value' => 'a', 'label' => 'A', 'sort_order' => 0, 'translations' => null,
]);
$this->assertSame(
['value' => 'a', 'label' => 'A', 'sort_order' => 0],
$option->toJsonShape(),
);
}
public function test_to_json_shape_includes_translations(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
$option = FormFieldOption::factory()->forField($field)->create([
'value' => 'sm', 'label' => 'Small', 'sort_order' => 1,
'translations' => ['nl' => 'Klein', 'de' => 'Klein'],
]);
$this->assertSame(
[
'value' => 'sm',
'label' => 'Small',
'sort_order' => 1,
'translations' => ['nl' => 'Klein', 'de' => 'Klein'],
],
$option->toJsonShape(),
);
}
public function test_unique_constraint_blocks_duplicate_value_per_owner(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldOption::factory()->forField($field)->create([
'value' => 'dup', 'label' => 'A', 'sort_order' => 0,
]);
$this->expectException(QueryException::class);
FormFieldOption::factory()->forField($field)->create([
'value' => 'dup', 'label' => 'B', 'sort_order' => 1,
]);
}
public function test_options_for_returns_options_in_sort_order(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldOption::factory()->forField($field)->create(['value' => 'c', 'label' => 'C', 'sort_order' => 2]);
FormFieldOption::factory()->forField($field)->create(['value' => 'a', 'label' => 'A', 'sort_order' => 0]);
FormFieldOption::factory()->forField($field)->create(['value' => 'b', 'label' => 'B', 'sort_order' => 1]);
$options = app(FormFieldOptionService::class)->optionsFor($field);
$this->assertSame(['a', 'b', 'c'], $options->pluck('value')->all());
}
public function test_replace_options_creates_rows_transactionally(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
$service = app(FormFieldOptionService::class);
$service->replaceOptions($field, [
['value' => 'red', 'label' => 'Red', 'sort_order' => 0],
['value' => 'green', 'label' => 'Green', 'sort_order' => 1],
]);
$this->assertSame(['red', 'green'], $service->optionsFor($field)->pluck('value')->all());
}
public function test_replace_options_invalid_specs_roll_back_no_partial_state(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
$service = app(FormFieldOptionService::class);
$service->replaceOptions($field, [
['value' => 'old', 'label' => 'Old', 'sort_order' => 0],
]);
try {
$service->replaceOptions($field, [
['value' => 'new1', 'label' => 'New 1', 'sort_order' => 0],
['value' => '', 'label' => 'bad', 'sort_order' => 1],
]);
$this->fail('Expected InvalidOptionSpecException.');
} catch (InvalidOptionSpecException) {
// expected
}
$this->assertSame(['old'], $service->optionsFor($field)->pluck('value')->all());
}
public function test_replace_options_emits_activity_log_on_field_only(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
$library = FormFieldLibrary::factory()->create(['organisation_id' => $org->id]);
$service = app(FormFieldOptionService::class);
$service->replaceOptions($field, [
['value' => 'a', 'label' => 'A', 'sort_order' => 0],
]);
$service->replaceOptions($library, [
['value' => 'b', 'label' => 'B', 'sort_order' => 0],
]);
$fieldEvent = Activity::query()
->where('subject_type', 'form_field')
->where('subject_id', $field->id)
->where('description', 'field.options_replaced')
->first();
$this->assertNotNull($fieldEvent);
$this->assertSame(
[['value' => 'a', 'label' => 'A', 'sort_order' => 0]],
$fieldEvent->properties->get('options'),
);
$this->assertNull(Activity::query()
->where('subject_type', 'form_field_library')
->where('description', 'field.options_replaced')
->first());
}
public function test_copy_options_clones_every_row_including_translations_and_sort_order(): void
{
$org = Organisation::factory()->create();
$library = FormFieldLibrary::factory()->create(['organisation_id' => $org->id]);
FormFieldOption::factory()->forLibrary($library)->create([
'value' => 'one', 'label' => 'One', 'sort_order' => 1,
'translations' => ['nl' => 'Een'],
]);
FormFieldOption::factory()->forLibrary($library)->create([
'value' => 'two', 'label' => 'Two', 'sort_order' => 0,
'translations' => null,
]);
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
app(FormFieldOptionService::class)->copyOptions($library, $field);
$copied = app(FormFieldOptionService::class)->optionsFor($field);
$this->assertCount(2, $copied);
$this->assertSame(['two', 'one'], $copied->pluck('value')->all());
$this->assertSame(['nl' => 'Een'], $copied->firstWhere('value', 'one')->translations);
$this->assertNull($copied->firstWhere('value', 'two')->translations);
}
public function test_copy_options_emits_no_activity_log(): void
{
$org = Organisation::factory()->create();
$library = FormFieldLibrary::factory()->create(['organisation_id' => $org->id]);
FormFieldOption::factory()->forLibrary($library)->create(['value' => 'a', 'label' => 'A', 'sort_order' => 0]);
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
app(FormFieldOptionService::class)->copyOptions($library, $field);
$this->assertNull(Activity::query()
->where('description', 'field.options_replaced')
->first());
}
public function test_to_json_shape_byte_equal_to_contract(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
$service = app(FormFieldOptionService::class);
$service->replaceOptions($field, [
['value' => 'red', 'label' => 'Red', 'sort_order' => 0],
['value' => 'green', 'label' => 'Green', 'sort_order' => 1, 'translations' => ['nl' => 'Groen']],
]);
$shape = $service->toJsonShape($service->optionsFor($field));
$this->assertSame(
[
['value' => 'red', 'label' => 'Red', 'sort_order' => 0],
['value' => 'green', 'label' => 'Green', 'sort_order' => 1, 'translations' => ['nl' => 'Groen']],
],
$shape,
);
}
public function test_assert_specs_valid_rejects_non_array_spec(): void
{
$this->expectException(InvalidOptionSpecException::class);
app(FormFieldOptionService::class)->assertSpecsValid(['not-an-array']);
}
public function test_assert_specs_valid_rejects_missing_or_oversized_value(): void
{
$service = app(FormFieldOptionService::class);
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['label' => 'L', 'sort_order' => 0],
]));
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => '', 'label' => 'L', 'sort_order' => 0],
]));
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => str_repeat('x', 256), 'label' => 'L', 'sort_order' => 0],
]));
}
public function test_assert_specs_valid_rejects_missing_or_oversized_label(): void
{
$service = app(FormFieldOptionService::class);
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => 'v', 'sort_order' => 0],
]));
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => 'v', 'label' => '', 'sort_order' => 0],
]));
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => 'v', 'label' => str_repeat('y', 256), 'sort_order' => 0],
]));
}
public function test_assert_specs_valid_rejects_bad_sort_order(): void
{
$service = app(FormFieldOptionService::class);
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => 'v', 'label' => 'L'],
]));
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => 'v', 'label' => 'L', 'sort_order' => '0'],
]));
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => 'v', 'label' => 'L', 'sort_order' => -1],
]));
}
public function test_assert_specs_valid_rejects_translations_not_array(): void
{
$this->expectException(InvalidOptionSpecException::class);
app(FormFieldOptionService::class)->assertSpecsValid([
['value' => 'v', 'label' => 'L', 'sort_order' => 0, 'translations' => 'not-array'],
]);
}
public function test_assert_specs_valid_rejects_invalid_locale_key(): void
{
$this->expectException(InvalidOptionSpecException::class);
app(FormFieldOptionService::class)->assertSpecsValid([
['value' => 'v', 'label' => 'L', 'sort_order' => 0, 'translations' => ['XX' => 'bad']],
]);
}
public function test_assert_specs_valid_rejects_invalid_translated_value(): void
{
$service = app(FormFieldOptionService::class);
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => 'v', 'label' => 'L', 'sort_order' => 0, 'translations' => ['nl' => '']],
]));
$this->assertThrowsInvalidSpec(fn () => $service->assertSpecsValid([
['value' => 'v', 'label' => 'L', 'sort_order' => 0, 'translations' => ['nl' => str_repeat('a', 256)]],
]));
}
public function test_assert_specs_valid_rejects_duplicate_values(): void
{
$this->expectException(InvalidOptionSpecException::class);
app(FormFieldOptionService::class)->assertSpecsValid([
['value' => 'dup', 'label' => 'A', 'sort_order' => 0],
['value' => 'dup', 'label' => 'B', 'sort_order' => 1],
]);
}
public function test_scope_isolates_options_per_organisation_both_owner_types(): void
{
[$orgA, $fieldA, $libraryA] = $this->seedOrgWithOptions();
[$orgB, $fieldB, $libraryB] = $this->seedOrgWithOptions();
$this->withOrgRoute($orgA);
$ids = FormFieldOption::query()->pluck('owner_id')->sort()->values()->all();
$expected = collect([$fieldA->id, $libraryA->id])->sort()->values()->all();
$this->assertSame($expected, $ids);
// Escape hatch.
$this->assertSame(
4,
FormFieldOption::query()->withoutGlobalScope(FormFieldOptionScope::class)->count(),
);
$this->assertSame(2, FormFieldOption::query()->count());
}
public function test_cascade_options_deleted_on_field_soft_delete(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldOption::factory()->forField($field)->create(['value' => 'a', 'label' => 'A']);
$this->assertSame(1, FormFieldOption::query()->withoutGlobalScopes()
->where('owner_id', $field->id)->count());
$field->delete(); // soft delete on FormField
$this->assertSame(0, FormFieldOption::query()->withoutGlobalScopes()
->where('owner_id', $field->id)->count());
}
public function test_cascade_options_deleted_on_field_force_delete(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldOption::factory()->forField($field)->create(['value' => 'a', 'label' => 'A']);
$field->forceDelete();
$this->assertSame(0, FormFieldOption::query()->withoutGlobalScopes()
->where('owner_id', $field->id)->count());
}
public function test_cascade_options_deleted_on_library_delete(): void
{
$org = Organisation::factory()->create();
$library = FormFieldLibrary::factory()->create(['organisation_id' => $org->id]);
FormFieldOption::factory()->forLibrary($library)->create(['value' => 'a', 'label' => 'A']);
$library->delete();
$this->assertSame(0, FormFieldOption::query()->withoutGlobalScopes()
->where('owner_id', $library->id)->count());
}
/** @return array{0:Organisation,1:FormField,2:FormFieldLibrary} */
private function seedOrgWithOptions(): array
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
$library = FormFieldLibrary::factory()->create(['organisation_id' => $org->id]);
FormFieldOption::factory()->forField($field)->create(['value' => 'fld-'.$field->id, 'label' => 'F']);
FormFieldOption::factory()->forLibrary($library)->create(['value' => 'lib-'.$library->id, 'label' => 'L']);
return [$org, $field, $library];
}
private function withOrgRoute(Organisation $org): void
{
$route = new Route(['GET'], '/_test', static fn () => null);
$route->bind(request());
$route->setParameter('organisation', $org);
request()->setRouteResolver(static fn () => $route);
}
private function assertThrowsInvalidSpec(callable $fn): void
{
try {
$fn();
} catch (InvalidOptionSpecException) {
$this->assertTrue(true);
return;
}
$this->fail('Expected InvalidOptionSpecException, none thrown.');
}
}

22
api/tests/Feature/FormBuilder/ValidationRules/FormFieldValidationRuleBackfillTest.php
View File

@@ -31,13 +31,15 @@ final class FormFieldValidationRuleBackfillTest extends TestCase
public function test_forward_migration_backfills_rows_with_field_type_dispatch(): void
{
// Roll back: 2 WS-5c migrations (create-conditional-logic-conditions,
// Roll back: 1 WS-5d migration (create-options) +
// 4 WS-5c migrations (drop-conditional-logic-col,
// backfill-conditional-logic, create-conditional-logic-conditions,
// create-conditional-logic-groups) + 5 WS-5b migrations
// (drop-cols + configs-backfill + create-configs +
// validation-rules-backfill + create-validation-rules) = 7.
// validation-rules-backfill + create-validation-rules) = 10.
// Brings us to the pre-WS-5b state: validation_rules JSON column
// present, no relational tables for WS-5b.
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
// present, no relational tables for WS-5b/c/d.
$this->artisan('migrate:rollback', ['--step' => 10])->assertSuccessful();
$this->assertFalse(Schema::hasTable('form_field_validation_rules'));
$this->assertTrue(Schema::hasColumn('form_fields', 'validation_rules'));
@@ -98,7 +100,7 @@ final class FormFieldValidationRuleBackfillTest extends TestCase
// (validation_rules JSON column present; no relational tables for
// WS-5b). Step count: drop-cols + configs-backfill + create-configs
// + validation-rules-backfill + create-validation-rules = 5.
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
$this->artisan('migrate:rollback', ['--step' => 10])->assertSuccessful();
$fieldId = $this->seedFieldWithJson([
'field_type' => 'TAG_PICKER',
@@ -122,7 +124,7 @@ final class FormFieldValidationRuleBackfillTest extends TestCase
// (validation_rules JSON column present; no relational tables for
// WS-5b). Step count: drop-cols + configs-backfill + create-configs
// + validation-rules-backfill + create-validation-rules = 5.
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
$this->artisan('migrate:rollback', ['--step' => 10])->assertSuccessful();
$fieldId = $this->seedFieldWithJson([
'field_type' => 'TEXT',
@@ -149,7 +151,7 @@ final class FormFieldValidationRuleBackfillTest extends TestCase
// (validation_rules JSON column present; no relational tables for
// WS-5b). Step count: drop-cols + configs-backfill + create-configs
// + validation-rules-backfill + create-validation-rules = 5.
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
$this->artisan('migrate:rollback', ['--step' => 10])->assertSuccessful();
$this->seedFieldWithJson([
'field_type' => 'TEXT',
@@ -166,7 +168,7 @@ final class FormFieldValidationRuleBackfillTest extends TestCase
// (validation_rules JSON column present; no relational tables for
// WS-5b). Step count: drop-cols + configs-backfill + create-configs
// + validation-rules-backfill + create-validation-rules = 5.
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
$this->artisan('migrate:rollback', ['--step' => 10])->assertSuccessful();
$this->seedFieldWithJson([
'field_type' => 'BOOLEAN',
@@ -185,7 +187,7 @@ final class FormFieldValidationRuleBackfillTest extends TestCase
// full-back-then-full-forward cycle — rolling back all WS-5b
// migrations restores the pre-WS-5b state (columns present on
// source tables; validation rules relational table gone).
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
$this->artisan('migrate:rollback', ['--step' => 10])->assertSuccessful();
[$numberId] = $this->seedFields();
$this->artisan('migrate')->assertSuccessful();
@@ -200,7 +202,7 @@ final class FormFieldValidationRuleBackfillTest extends TestCase
// Roll back WS-5b fully → column reappears and carries canonical JSON
// reconstructed from the relational rows.
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
$this->artisan('migrate:rollback', ['--step' => 10])->assertSuccessful();
$this->assertTrue(Schema::hasColumn('form_fields', 'validation_rules'));
$field = DB::table('form_fields')->where('id', $numberId)->first();