bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(form-field): add form_field_options table, service, scope, cascade

Browse Source 
Fourth and final WS-5 sibling. Polymorphic morph-owned table for the
RADIO / SELECT / MULTISELECT / CHECKBOX_LIST option rows, shared
between form_fields and form_field_library via the owner_type
discriminator. Matches the WS-5a (bindings) / WS-5b (validation_rules
+ configs) pattern one-for-one: dedicated service as single writer,
UNION-over-two-owner-chains scope, shared cascade observer.

Row shape:
  - value         canonical storage value (string ≤255, UNIQUE per owner)
  - label         default-locale display label (string ≤255)
  - sort_order    int unsigned
  - translations  JSON { "<locale>": "<translated label>" }

The UNIQUE(owner_type, owner_id, value) index ffo_owner_value_unique
is the seed-bug guard — duplicate values per field have no semantic
meaning and must fail at both the service layer (assertSpecsValid)
and the DB level.

Activity log: field.options_replaced emits on FormField subject only,
per the §6.7 WS-5a / §17.4.2 WS-5b convention that library-level
changes are silent in activity log.

No production reads yet. The form_fields.options and
form_field_library.options JSON columns remain the active source of
truth until the commit-3 reader switch — accessing $field->options
still resolves through the JSON cast in commit 1, so model tests
exercise the new morphMany via $field->options() (explicit relation
call). Both FormField and FormFieldLibrary now carry an `options`
morphMany alongside `bindings`, `validation_rules`, and `configs`.

Cascade: FormFieldChildTablesCascadeObserver gains form_field_options
as the fourth child cleaned on owner delete (both FormField soft/
force-delete and FormFieldLibrary delete).

Migration step-count tests in WS-5a/b/c bumped by 1 to account for
the new create_form_field_options_table on the migration stack.

Base scope-class extraction across the four siblings — deliberately
deferred to a follow-up work package per addendum §17.4.3 / §17.5.3.
Now that all four concrete implementations exist, the "what actually
varies" question can be answered empirically.

Tests: 1158 → 1182 green (+24 tests / +42 assertions).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-04-25 02:07:53 +02:00
parent e17fc7c2f4
commit 11588623c5
13 changed files with 1078 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
api/database/factories/FormBuilder/FormFieldOptionFactory.php Normal file
View File

@@ -0,0 +1,63 @@
<?php
declare(strict_types=1);
namespace Database\Factories\FormBuilder;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldLibrary;
use App\Models\FormBuilder\FormFieldOption;
use Illuminate\Database\Eloquent\Factories\Factory;
/** @extends Factory<FormFieldOption> */
final class FormFieldOptionFactory extends Factory
{
protected $model = FormFieldOption::class;
/** @return array<string, mixed> */
public function definition(): array
{
$value = $this->faker->unique()->slug(2);
return [
'owner_type' => 'form_field',
'owner_id' => FormField::factory(),
'value' => $value,
'label' => ucfirst(str_replace('-', ' ', $value)),
'sort_order' => 0,
'translations' => null,
];
}
public function forField(FormField $field): static
{
return $this->state(fn () => [
'owner_type' => 'form_field',
'owner_id' => $field->id,
]);
}
public function forLibrary(FormFieldLibrary $library): static
{
return $this->state(fn () => [
'owner_type' => 'form_field_library',
'owner_id' => $library->id,
]);
}
/**
* @param list<string> $locales
*/
public function withTranslations(array $locales = ['en', 'de']): static
{
return $this->state(function (array $attributes) use ($locales) {
$base = (string) ($attributes['label'] ?? 'Option');
$bag = [];
foreach ($locales as $locale) {
$bag[$locale] = $base.' ('.$locale.')';
}
return ['translations' => $bag];
});
}
}

61
api/database/migrations/2026_04_27_100000_create_form_field_options_table.php Normal file
View File

@@ -0,0 +1,61 @@
<?php
declare(strict_types=1);
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;
/**
* WS-5d commit 1 of 5 — fourth and final WS-5 sibling. Polymorphic
* morph-owned table for the RADIO / SELECT / MULTISELECT / CHECKBOX_LIST
* option rows, shared between form_fields and form_field_library via
* the `owner_type` discriminator (matches WS-5a / WS-5b morph alias
* registration in AppServiceProvider::registerMorphMap).
*
* Row shape:
* - value canonical storage value (string ≤255)
* - label default-locale display label (string ≤255)
* - sort_order stable order within owner (uint)
* - translations { "<locale>": "<translated label>" } — JSON nullable
*
* UNIQUE(owner_type, owner_id, value) is the seed-bug guard: duplicate
* values per field have no semantic meaning and must fail at both the
* service-level (assertSpecsValid) and the DB-level. Index name
* `ffo_owner_value_unique` is a stable handle for future migrations.
*
* No soft delete — options are physical state, not audit. Submission
* snapshots carry the historical shape (matches §17.4 / §17.5 sibling
* convention). Cascade on owner delete is handled by
* FormFieldChildTablesCascadeObserver.
*/
return new class extends Migration
{
public function up(): void
{
Schema::create('form_field_options', function (Blueprint $table) {
$table->ulid('id')->primary();
$table->string('owner_type', 40);
$table->ulid('owner_id');
$table->string('value', 255);
$table->string('label', 255);
$table->unsignedInteger('sort_order')->default(0);
$table->json('translations')->nullable();
$table->timestamps();
$table->index(
['owner_type', 'owner_id', 'sort_order'],
'ffo_owner_sort_idx',
);
$table->unique(
['owner_type', 'owner_id', 'value'],
'ffo_owner_value_unique',
);
});
}
public function down(): void
{
Schema::dropIfExists('form_field_options');
}
};