bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(form-builder): align binding registry with model column reality (WS-6)

Browse Source 
Three renames (registry → matches actual Eloquent model column):
  - person.phone_number       → person.phone
  - company.email             → company.contact_email
  - company.phone_number      → company.contact_phone

Six removals (registry attribute does not exist as model column,
intentionally deferred):
  - person.dietary_preferences  (custom_fields JSON path; BACKLOG
    FORM-BINDING-JSON-PATH)
  - artist.email                (Artist model absent + column absent)
  - artist.stage_name           (column absent)
  - artist.tech_rider           (column absent)
  - artist.hospitality_rider    (column absent)
  - artist entity removed entirely (no v1 bindable attributes)

Decisions documented inline in binding_targets.php and tracked
via BACKLOG entries (Task 4 of this session).

Tests touched:
- BindingTypeRegistryTest:
    test_resolve_person_dietary_preferences_returns_collection_array →
      renamed test_resolve_collection_attribute_returns_collection_array,
      uses Config::set to inject a synthetic 'test_entity.tags' collection
      target. v1 has no production collection targets (BACKLOG
      FORM-BINDING-JSON-PATH).
    test_validate_append_strategy_accepts_collection_target — same pattern.
    test_entities_returns_known_entities — drop 'artist' from expected list.
    test_attributes_for_person_includes_email_and_dietary_preferences →
      renamed _includes_email_and_phone (the renamed attribute).
- AppendStrategyRequiresCollectionTargetTest:
    test_passes_with_collection_target — same Config::set synthetic-
    target pattern.
- MaxOneIdentityKeyPerTargetEntityTest:
    test_passes_with_one_identity_key_each_on_different_entities —
    'company.email' → 'company.contact_email' to match registry rename.

Refs: WS-6 sessie 3a binding-target drift audit

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-04-28 20:26:15 +02:00
parent 383b4fc5a3
commit 0e986f42cb
4 changed files with 69 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
api/tests/Unit/FormBuilder/Publishing/MaxOneIdentityKeyPerTargetEntityTest.php
View File

@@ -21,7 +21,7 @@ final class MaxOneIdentityKeyPerTargetEntityTest extends TestCase
FormField::factory()->create(['form_schema_id' => $schema->id]);
$schema->load('fields.bindings');
$result = (new MaxOneIdentityKeyPerTargetEntity())->evaluate($schema);
$result = (new MaxOneIdentityKeyPerTargetEntity)->evaluate($schema);
$this->assertTrue($result->passed);
}
@@ -33,7 +33,7 @@ final class MaxOneIdentityKeyPerTargetEntityTest extends TestCase
->create(['is_identity_key' => true]);
$schema->load('fields.bindings');
$result = (new MaxOneIdentityKeyPerTargetEntity())->evaluate($schema);
$result = (new MaxOneIdentityKeyPerTargetEntity)->evaluate($schema);
$this->assertTrue($result->passed);
}
@@ -48,7 +48,7 @@ final class MaxOneIdentityKeyPerTargetEntityTest extends TestCase
->create(['is_identity_key' => true]);
$schema->load('fields.bindings');
$result = (new MaxOneIdentityKeyPerTargetEntity())->evaluate($schema);
$result = (new MaxOneIdentityKeyPerTargetEntity)->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame('person', $result->context['entity']);
}
@@ -60,11 +60,11 @@ final class MaxOneIdentityKeyPerTargetEntityTest extends TestCase
$f2 = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($f1)->entityOwned('person', 'email')
->create(['is_identity_key' => true]);
FormFieldBinding::factory()->forField($f2)->entityOwned('company', 'email')
FormFieldBinding::factory()->forField($f2)->entityOwned('company', 'contact_email')
->create(['is_identity_key' => true]);
$schema->load('fields.bindings');
$result = (new MaxOneIdentityKeyPerTargetEntity())->evaluate($schema);
$result = (new MaxOneIdentityKeyPerTargetEntity)->evaluate($schema);
$this->assertTrue($result->passed);
}
}