feat(form-builder): add BindingTypeRegistry as single source of truth for target shapes (WS-6)

Config-driven mapping from (target_entity, target_attribute) to storage shape (scalar/collection/relation), PHP type, and identity-key eligibility. Replaces any name-suffix matching (e.g. _tags, _skills) — those are convention-not-contract and reject by design. Used by publish guards now and (in session 2) by FormBindingApplicator. Refs: RFC-WS-6.md §4 (V1) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-25 22:41:25 +02:00
parent b2e9ef8824
commit 0dd991c688
7 changed files with 356 additions and 0 deletions
--- a/api/tests/Unit/FormBuilder/Bindings/BindingTypeRegistryTest.php
+++ b/api/tests/Unit/FormBuilder/Bindings/BindingTypeRegistryTest.php
@@ -0,0 +1,103 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Unit\FormBuilder\Bindings;
+
+use App\Enums\FormBuilder\BindingTargetType;
+use App\Enums\FormBuilder\FormFieldBindingMergeStrategy;
+use App\Exceptions\FormBuilder\InvalidBindingTargetException;
+use App\Exceptions\FormBuilder\UnknownBindingTargetException;
+use App\FormBuilder\Bindings\BindingTypeRegistry;
+use Tests\TestCase;
+
+final class BindingTypeRegistryTest extends TestCase
+{
+    public function test_resolve_person_email_returns_scalar_string_identity_eligible(): void
+    {
+        $meta = $this->registry()->resolve('person', 'email');
+
+        $this->assertSame(BindingTargetType::SCALAR, $meta->type);
+        $this->assertSame('string', $meta->php);
+        $this->assertTrue($meta->identityKeyEligible);
+    }
+
+    public function test_resolve_person_dietary_preferences_returns_collection_array(): void
+    {
+        $meta = $this->registry()->resolve('person', 'dietary_preferences');
+
+        $this->assertSame(BindingTargetType::COLLECTION, $meta->type);
+        $this->assertSame('array', $meta->php);
+        $this->assertFalse($meta->identityKeyEligible);
+    }
+
+    public function test_resolve_unknown_attribute_throws(): void
+    {
+        $this->expectException(UnknownBindingTargetException::class);
+        $this->registry()->resolve('person', 'unknown_field');
+    }
+
+    public function test_is_identity_key_eligible_truth_table(): void
+    {
+        $registry = $this->registry();
+        $this->assertTrue($registry->isIdentityKeyEligible('person', 'email'));
+        $this->assertFalse($registry->isIdentityKeyEligible('person', 'first_name'));
+        $this->assertFalse($registry->isIdentityKeyEligible('person', 'unknown_field'));
+    }
+
+    public function test_validate_append_strategy_rejects_scalar_target(): void
+    {
+        $this->expectException(InvalidBindingTargetException::class);
+        $this->registry()->validateAppendStrategy(
+            'person',
+            'email',
+            FormFieldBindingMergeStrategy::Append,
+        );
+    }
+
+    public function test_validate_append_strategy_accepts_collection_target(): void
+    {
+        $this->registry()->validateAppendStrategy(
+            'person',
+            'dietary_preferences',
+            FormFieldBindingMergeStrategy::Append,
+        );
+
+        $this->expectNotToPerformAssertions();
+    }
+
+    public function test_validate_append_strategy_skips_other_strategies(): void
+    {
+        $this->registry()->validateAppendStrategy(
+            'person',
+            'email',
+            FormFieldBindingMergeStrategy::Overwrite,
+        );
+
+        $this->expectNotToPerformAssertions();
+    }
+
+    public function test_entities_returns_known_entities(): void
+    {
+        $entities = $this->registry()->entities();
+        sort($entities);
+        $this->assertSame(['artist', 'company', 'person', 'user'], $entities);
+    }
+
+    public function test_attributes_for_person_includes_email_and_dietary_preferences(): void
+    {
+        $attributes = $this->registry()->attributesFor('person');
+        $this->assertContains('email', $attributes);
+        $this->assertContains('dietary_preferences', $attributes);
+    }
+
+    public function test_attributes_for_unknown_entity_returns_empty_list(): void
+    {
+        $this->assertSame([], $this->registry()->attributesFor('unknown'));
+    }
+
+    private function registry(): BindingTypeRegistry
+    {
+        return $this->app->make(BindingTypeRegistry::class);
+    }
+}