fix(app): resolve Bucket A/C/D lint items (trivial / style / Vuetify class)
WS-3 session 1b-ii Task 4 (audit Buckets A, C, D — 26 items resolved
this commit; 24 indent items in useTimeSlotDropdown.ts remain — see
deviations).
Bucket A — Trivial fixes (12 items resolved):
- A.1: second-pass eslint --fix on App.vue resolved 4 multi-attribute
warnings. AppKpiCard / PortalLayout / PublicLayout
lines-around-comment items were attempted via blank-line addition,
but that introduced an equal number of vue/block-tag-newline
errors (the rules conflict at the SFC <script>-tag boundary). The
blank-line additions were reverted; net-zero, the 3 items remain
for a 1b-iii .eslintrc.cjs override decision.
- A.3: 6 unused-imports / unused-vars manual deletes:
* OrganisationSwitcher.vue: removed orphan toggleMenu() function
* CreateShiftDialog.vue: removed unused 'scenario' from destructure
* pages/events/[id]/time-slots/index.vue: removed unused 'event'
slot scope binding (template <#default="{ event }"> → <#default>)
* pages/organisation/companies.vue: removed unused authStore
declaration + import
* pages/platform/activity-log/index.vue: removed unused
search/searchDebounced pair
* PersonDetailPanel.vue:77: removed redundant single-statement
if-braces (curly autofix that the original pass didn't reach)
Bucket C — Style preference (8 items resolved):
- DismissFailureDialog.vue:43: collapsed two consecutive `if cond return false`
branches into `return !(cond)`
- FormFailureDetail.vue:44: replaced `void clipboard.writeText(...)` with
`clipboard.writeText(...).catch(() => {})` — fire-and-forget with
silent rejection (the no-void rule wants the void operator gone;
.catch() handles it semantically).
- AssignShiftDialog.vue:40-46: hasOverlapWarning collapsed from
always-false branching to `computed(() => false)` (the early-return
was dead code; backend enforces the constraint).
- SectionsShiftsPanel.vue:333 + registration-fields.vue:335: rewrote
`:delay-on-touch-only="true"` to attribute-shorthand `delay-on-touch-only`.
- AssignPersonDialog.vue:120-128: collapsed two `if outer { if inner ... }`
pairs into single `if (outer && inner)` form (sonarjs/no-collapsible-if).
- useImpersonationStore.ts:99-104: collapsed the same nested-if pattern
into `if (!data.data.active && state.value)`.
Bucket D — Vuetify utility class rename (5 items, 3 files):
- ml-1 → ms-1 (PersonDetailPanel:271, SectionsShiftsPanel:357,
AssignPersonDialog:496)
- pl-4 → ps-4 (AssignPersonDialog:457)
- ml-auto → ms-auto (AssignPersonDialog:471)
LTR/RTL-aware Vuetify utilities, matching the Vuexy reference idiom.
Tests + typecheck verified green.
Lint baseline: 62 → 36.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -40,10 +40,8 @@ const noteRequired = computed(() => reason.value === 'other')
|
||||
const canSubmit = computed(() => {
|
||||
if (reason.value === null)
|
||||
return false
|
||||
if (noteRequired.value && note.value.trim() === '')
|
||||
return false
|
||||
|
||||
return true
|
||||
return !(noteRequired.value && note.value.trim() === '')
|
||||
})
|
||||
|
||||
watch(isDialogOpen, open => {
|
||||
|
||||
@@ -41,7 +41,7 @@ const dismissDialogOpen = ref(false)
|
||||
|
||||
function copyText(text: string): void {
|
||||
if (navigator?.clipboard)
|
||||
void navigator.clipboard.writeText(text)
|
||||
navigator.clipboard.writeText(text).catch(() => {})
|
||||
}
|
||||
|
||||
const formattedContext = computed(() => {
|
||||
|
||||
@@ -27,11 +27,6 @@ const roleColor = (role: string) => ({
|
||||
volunteer_coordinator: 'secondary',
|
||||
}[role] ?? 'default')
|
||||
|
||||
function toggleMenu() {
|
||||
if (hasMultiple.value)
|
||||
isMenuOpen.value = !isMenuOpen.value
|
||||
}
|
||||
|
||||
function selectOrg(id: string) {
|
||||
authStore.setActiveOrganisation(id)
|
||||
isMenuOpen.value = false
|
||||
|
||||
@@ -74,9 +74,8 @@ function calculateAge(dateStr: string): number | null {
|
||||
let age = today.getFullYear() - birth.getFullYear()
|
||||
const monthDiff = today.getMonth() - birth.getMonth()
|
||||
const dayDiff = today.getDate() - birth.getDate()
|
||||
if (monthDiff < 0 || (monthDiff === 0 && dayDiff < 0)) {
|
||||
if (monthDiff < 0 || (monthDiff === 0 && dayDiff < 0))
|
||||
age--
|
||||
}
|
||||
if (age < 0 || age > 130)
|
||||
return null
|
||||
|
||||
@@ -269,7 +268,7 @@ function handleManualLink(userId: string) {
|
||||
Mogelijke match gevonden
|
||||
<VChip
|
||||
size="x-small"
|
||||
class="ml-1"
|
||||
class="ms-1"
|
||||
variant="outlined"
|
||||
>
|
||||
{{ person.pending_identity_match.confidence_label }}
|
||||
|
||||
@@ -37,13 +37,8 @@ const generalError = computed(() => {
|
||||
})
|
||||
|
||||
// Check for overlap warning
|
||||
const hasOverlapWarning = computed(() => {
|
||||
if (!selectedPersonId.value || !props.shift)
|
||||
return false
|
||||
|
||||
// This is informational — the backend enforces the actual constraint
|
||||
return false
|
||||
})
|
||||
// This is informational — the backend enforces the actual constraint
|
||||
const hasOverlapWarning = computed(() => false)
|
||||
|
||||
const personItems = computed(() =>
|
||||
persons.value.map((p: Person) => ({
|
||||
|
||||
@@ -37,7 +37,7 @@ const { data: eventDetail } = useEventDetail(orgIdRef, eventIdRef)
|
||||
const sectionRef = computed(() => props.section ?? null)
|
||||
|
||||
// Determine dropdown scenario
|
||||
const { scenario, showInfoTooltip, hasGroups, tooltipText, fetchParams, sortedItems } = useTimeSlotDropdown(
|
||||
const { showInfoTooltip, hasGroups, tooltipText, fetchParams, sortedItems } = useTimeSlotDropdown(
|
||||
eventDetail,
|
||||
sectionRef,
|
||||
)
|
||||
|
||||
@@ -330,7 +330,7 @@ function onSectionCreated(payload: { name: string; redirectedToParent: boolean;
|
||||
drag-class="section-drag"
|
||||
:animation="200"
|
||||
:delay="100"
|
||||
:delay-on-touch-only="true"
|
||||
delay-on-touch-only
|
||||
direction="vertical"
|
||||
class="v-list v-list--nav v-list--density-compact"
|
||||
@end="onDragEnd"
|
||||
@@ -354,7 +354,7 @@ function onSectionCreated(payload: { name: string; redirectedToParent: boolean;
|
||||
<span>{{ element.name }}</span>
|
||||
<span
|
||||
v-if="element.type === 'cross_event' && parentEvent"
|
||||
class="text-caption text-medium-emphasis ml-1"
|
||||
class="text-caption text-medium-emphasis ms-1"
|
||||
>
|
||||
· {{ parentEvent.name }}
|
||||
</span>
|
||||
|
||||
@@ -117,15 +117,11 @@ const filteredPersons = computed(() => {
|
||||
return false
|
||||
}
|
||||
|
||||
if (selectedCrowdType.value) {
|
||||
if (person.crowd_type?.system_type !== selectedCrowdType.value)
|
||||
return false
|
||||
}
|
||||
if (selectedCrowdType.value && person.crowd_type?.system_type !== selectedCrowdType.value)
|
||||
return false
|
||||
|
||||
if (showOnlyAvailable.value) {
|
||||
if (!person.is_available || person.already_assigned)
|
||||
return false
|
||||
}
|
||||
if (showOnlyAvailable.value && (!person.is_available || person.already_assigned))
|
||||
return false
|
||||
|
||||
if (showRecommendedOnly.value) {
|
||||
const hasPreference = person.section_preferences.some(
|
||||
@@ -458,7 +454,7 @@ async function executeAssign(person: AssignablePerson) {
|
||||
</template>
|
||||
<div class="text-body-2 text-white">
|
||||
<strong>Aanbevolen omdat:</strong>
|
||||
<ul class="pl-4 mt-1 mb-0">
|
||||
<ul class="ps-4 mt-1 mb-0">
|
||||
<li
|
||||
v-for="(reason, i) in getRecommendationReasons(person)"
|
||||
:key="i"
|
||||
@@ -472,7 +468,7 @@ async function executeAssign(person: AssignablePerson) {
|
||||
v-if="person.crowd_type"
|
||||
size="x-small"
|
||||
variant="tonal"
|
||||
class="ml-auto"
|
||||
class="ms-auto"
|
||||
>
|
||||
{{ person.crowd_type.name }}
|
||||
</VChip>
|
||||
@@ -497,7 +493,7 @@ async function executeAssign(person: AssignablePerson) {
|
||||
{{ tag.name }}
|
||||
<span
|
||||
v-if="tag.proficiency"
|
||||
class="ml-1 font-italic"
|
||||
class="ms-1 font-italic"
|
||||
>
|
||||
({{ { beginner: 'beg.', experienced: 'erv.', expert: 'exp.' }[tag.proficiency] }})
|
||||
</span>
|
||||
|
||||
Reference in New Issue
Block a user